-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a module for implementing (sub-annual) time slices #852
base: main
Are you sure you want to change the base?
Conversation
* Adapt path to new data file location
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
=======================================
- Coverage 95.6% 90.3% -5.4%
=======================================
Files 46 47 +1
Lines 4333 4588 +255
=======================================
Hits 4143 4143
- Misses 190 445 +255
|
In the MESSAGE meeting just now, @behnam-zakeri mentioned that #680 might be related. |
@glatterf42 Related to the test, I have added an example of Westeros model via the Excel file, which is used by the code to create a Westeros scenario with time slices, exactly similar to the one we have in our published tutorials (Westeros_seasonality.ipynb). So, the only part missing will be to check if the output of these two models are the same or not.
|
Unfortunately, neither @behnam-zakeri nor me have enough time to finish this PR in time for the 3.10 milestone. We hope this will be better for 3.11, though. |
This PR supersedes iiasa/message-ix-models#197 as @khaeru suggested this tool might be better placed in message_ix.
@behnam-zakeri Please take a look at the changes. Several things come to mind before merging this:
README.rst
as was done foradd_year
)How to review
Check the above boxes plus:
developer (someone like the reviewer) will be able to understand what the code
does in the future.
PR checklist